search

darktable-org / dtdocs

darktable user manual
GNU General Public License v3.0
74 stars 74 forks source link

Change the checkbox label in the metadata editor #446

Closed victoryforce closed 2 years ago

victoryforce commented 2 years ago

The metadata editor contains a checkbox with the opposite meaning: 'visible', not 'hidden'.

elstoc commented 2 years ago

hmm I'm not sure about this one. I get where you're coming from but "hidden" and "not visible" mean the same thing and I'm not entirely happy with how that pair of "nots" reads in this sentence ("or not tagged as visible will not be exported").

I'm sure there's some less clunky sounding wording but I haven't thought of it yet...

Honestly I'd prefer it if the metadata preferences window used the terms private and hidden. Seems more consistent somehow.

victoryforce commented 2 years ago

"hidden" and "not visible" surely mean the same thing. But here we refer to a specific label in the GUI. So as long as "visible" is used in the program interface, we must refer to this exact name, otherwise the user will be confused by the discrepancy in the GUI and documentation.

I can swap two parts of this sentence so that 'nots' will be farther apart. So, intead of Metadata fields tagged as _private_ or not tagged as _visible_ will not be exported. it will be Metadata fields not tagged as _visible_ or tagged as _private_ will not be exported.

I think that sounds better. Is it good enough for you or will you try to find an even better wording?

elstoc commented 2 years ago

Metadata fields not tagged as visible or tagged as private will not be exported.

That could be potentially be misread as "metadata fields not tagged as visible or not tagged as private...". How about if we reversed the logic and said something like "Only metadata fields that are tagged as visible and are not tagged as private will be exported."

victoryforce commented 2 years ago

Reversed text sounds so much better! What amazes me is why I didn't come up with this. :) So I modified the PR with your suggestion.

elstoc commented 2 years ago

Thanks.