Closed elstoc closed 2 years ago
Otherwise i see no "technical errors"
Looks good for me when viewing the diffs ...
Looks good for me when viewing the diffs ...
Excellent. Thanks for reviewing. I'll probably do another quick copy-edit and then merge it later today.
@jenshannoschwalm: one question about the version number. I assume that this is an internal thing that will be incremented when the parameters change in a new version of darktable? What will happen with previously-overridden settings when this happens? Say I have tweaked version 4 and you create a version 5 - would my tweaks be carried over or would I have to re-tweak? If the latter, how would I know the version has changed?
Oh, my comment from mobile seems to be gone.
Yes, internal version but kept in darktablerc as before. NEW: whenever the version bumbs there can be a note shown requesting a confirm by the user like "understood"? If answered yes that note won't be shown again, otherwise whenever dt starts.
So far whenever there was a dt version jump as from 3.8->4.0 we made sure conf data are kept. This will be so later too. (I don't think the code is so messed it can't be done :-)
Have looked through your late mods, all changes are good for me regarding technical aspects.
Style wise, thank you is by far not enough!
Thank you for your kind words :)
Resolves #449