search

darktable-org / dtdocs

darktable user manual
GNU General Public License v3.0
74 stars 74 forks source link

(WIP) document v4.0 openCL changes #480

Closed elstoc closed 2 years ago

elstoc commented 2 years ago

Resolves #449

jenshannoschwalm commented 2 years ago

Otherwise i see no "technical errors"

jenshannoschwalm commented 2 years ago

Looks good for me when viewing the diffs ...

elstoc commented 2 years ago

Looks good for me when viewing the diffs ...

Excellent. Thanks for reviewing. I'll probably do another quick copy-edit and then merge it later today.

elstoc commented 2 years ago

@jenshannoschwalm: one question about the version number. I assume that this is an internal thing that will be incremented when the parameters change in a new version of darktable? What will happen with previously-overridden settings when this happens? Say I have tweaked version 4 and you create a version 5 - would my tweaks be carried over or would I have to re-tweak? If the latter, how would I know the version has changed?

jenshannoschwalm commented 2 years ago

Oh, my comment from mobile seems to be gone.

Yes, internal version but kept in darktablerc as before. NEW: whenever the version bumbs there can be a note shown requesting a confirm by the user like "understood"? If answered yes that note won't be shown again, otherwise whenever dt starts.

So far whenever there was a dt version jump as from 3.8->4.0 we made sure conf data are kept. This will be so later too. (I don't think the code is so messed it can't be done :-)

jenshannoschwalm commented 2 years ago

Have looked through your late mods, all changes are good for me regarding technical aspects.

Style wise, thank you is by far not enough!

elstoc commented 2 years ago

Thank you for your kind words :)