Closed lekum closed 1 year ago
PR amended, thanks @paperdigits for your comment.
Sorry to be such a picky turd, but the PO files can't change at all. If you can squash the two commits together, it should be fine. But any change to the PO files will screw up out translation app.
On September 14, 2022 12:49:01 PM PDT, "Alejandro Guirao Rodríguez" @.***> wrote:
PR amended, thanks @paperdigits for your comment.
-- Reply to this email directly or view it on GitHub: https://github.com/darktable-org/dtdocs/pull/522#issuecomment-1247229972 You are receiving this because you were mentioned.
Message ID: @.***>
No problem, I'll squash the two commits into one and force push. I supposed this decision could be done at merge (squash) time but no problem from my side.
Better to keep the PR clean. Thanks
Hi! Good catch on the typo, but we never ever edit PO files directly for dtdocs, they must be changed via weblate.
The change to the English markdown file can stay though.
Please amend your PR.
On September 14, 2022 11:22:29 AM PDT, "Alejandro Guirao Rodríguez" @.***> wrote: