Initial Color Eq docs based on documentation by Boris.

[paperdigits]

Color Eq docs based on a document sent to me by Boris.

darktable issues that might need labels adjusted if this is merged: https://github.com/darktable-org/darktable/pull/16633 https://github.com/darktable-org/darktable/pull/16543 https://github.com/darktable-org/darktable/pull/16446 https://github.com/darktable-org/darktable/pull/16400 https://github.com/darktable-org/darktable/pull/16301 https://github.com/darktable-org/darktable/pull/16279 https://github.com/darktable-org/darktable/pull/16236 https://github.com/darktable-org/darktable/pull/16089

[s7habo]

Hi Mica, here I am. How do we proceed now? I'm almost finished with Manual as a document. Tomorrow I can offer it.

[paperdigits]

@s7habo if you click on the "Files Change" tab on this page, you'll see the page I added. You can either add comments, click and edit it to propose changes, or make comments that I can accept as changes. You can see the flow for that here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

Feel free to add whatever you'd like!

[elstoc]

FYI we want to try and avoid too many images if possible, since it's a pain to re-create them every time the UI or functionality changes.

[s7habo]

@paperdigits is it ok for you if I comment like this?

I would hate to make sugestion about changes in the code itself because I have no idea how to use this language.

FYI we want to try and avoid too many images if possible, since it's a pain to re-create them every time the UI or functionality changes.

@elstoc I understand that this means more work, but it also means a lot of work to explain things to users afterwards, when there are hardly any visual examples for functions that are sometimes explained in a very technical way.

I will be happy to re-create them afterwards if the changes require it. When the time has come, you are welcome to contact me.

[paperdigits]

@s7habo yeah this is fine. If you can "suggest" the changes, then I can just click "accept" instead of having to copy and paste.

Thanks for the work, the range selection stuff is completely unrecoverable from just the UI itself :D

[elstoc]

@s7habo I don't mean no images but let's try to limit the number if we can and make them simple enough that they won't need too much maintenance later on. If we are using images to illustrate concepts, it's better to include only as much of the UI as you need to explain things. For example if you're trying to illustrate the shape of the curve when a parameter is applied, then if you only show the curve itself and not the rest of the module UI, it will probably never need to be updated again.

[s7habo]

.If we are using images to illustrate concepts, it's better to include only as much of the UI as you need to explain things. For example if you're trying to illustrate the shape of the curve when a parameter is applied, then if you only show the curve itself and not the rest of the module UI, it will probably never need to be updated again.

Ok. I will try to pay attention to it. I will continue now and then we can talk about the details.

[s7habo]

The point “effect radius” is still open. I'll deal with that tomorrow.

[s7habo]

I am now finished. I also have the whole thing as an odt document which I can offer together with screenshots. I can also provide the raw files that were used for screenshots.

[jenshannoschwalm]

A BIG thank you to all of you.

BTW I will check how/if the mask visualizing restriction mentioned by @ralfbrown can be avoided.

[ralfbrown]

I haven't looked at the code, but it's pretty clear the mask visualization uses the RGB channels rather than the alpha channel. It would take a reworking of the yellow masks generation in gamma.c to generate the red/blue masks with a new mask display mode (or two) and have the equalizer put the "strength" value on the alpha channel.

[jenshannoschwalm]

Yes but we have a way to pass thru the RGB data.

[paperdigits]

@elstoc I hope this is good enough for a first draft.

[elstoc]

BTW I've created a separate issue around central documentation of color pickers (https://github.com/darktable-org/dtdocs/issues/673)

[elstoc]

As the discussion is getting a bit hard to follow, and I wanted to do a bit of reorganisation, I have created another draft in a new PR #674