darktable-org / lua-scripts

155 stars 110 forks source link

fix for create_unique_filename not stopping at 99 #233

Closed Mark-64 closed 4 years ago

Mark-64 commented 4 years ago

Fix for this library function not stopping the count as it should. The issue is easily reproduced, just set the limit to something more manageable, like 10 ;-)

wpferguson commented 4 years ago

I tried to reproduce this on linux and windows and wasn't able to. I wrote a test script, called test_unique.lua, that exercises the create_unique_filename function. I'll include it here. Please run it against your unpatched library and let me know what happens. test_unique.zip

Mark-64 commented 4 years ago

You are right, there is no malfunction now. It turns out that I messed up with my fork of lua-scripts, so I was using a tweaked version of file.lua. If there was an issue, it has been fixed since then. I apologize for the inconvenience. Closing

wpferguson commented 4 years ago

No problem