search

darktable-org / lua-scripts

155 stars 110 forks source link

DB maintenance confirmation windows issue when lua scripts are active #252

Closed gadolf66 closed 4 years ago

gadolf66 commented 4 years ago

When I have two lua scripts enabled and darktable database maintenance window should pop up on close, it doesn't pop up and darktable never closes (because it's waiting for user input)

To reproduce, activate face_recognition and photils, set up database fragmentation ratio threshold to zero (to force the window to pop up all the time) and check for database maintenance to on close . Close darktable and reopen it, then close it again. The database maintenance window doesn't show up, and darktable doesn't quit unless you kill the process. To make it clear where darktable state is, call it from the terminal with -d all, so it shows clearly that it's waiting for user input on database maintenance. This is related to #5110 OS: ubuntu 20.04 darktable 3.1.0~git1736.a6fc3dc68 Opencl: no Second monitor: no

wpferguson commented 4 years ago

Could you try this with one of the scripts, then the other? Also could you try a different script and see if the problem repeats?

gadolf66 commented 4 years ago

The issue seems to be on photils only. Sorry having created a general issue for that. When I was working on the other issue I mentioned, I swear both scripts were causing the problem, but maybe I forgot to save lua.rc or something, while switching the active script. Now I let face_recognition enabled and did many open/close operations and the maitenance dialog showed up just fine. I will address the issue on the photils thread in pixls. Thanks.