search

darktable-org / lua-scripts

155 stars 110 forks source link

Fixed OpenInExplorer.lua so that it works with the latest Darktable r… #323

Closed carthurs closed 3 years ago

carthurs commented 3 years ago

…elease (3.4.0 for the API v6.1.0).

Tested on Windows 10 - previously the script would not load, giving an error popup in the darktable GUI.

wpferguson commented 3 years ago

What did the error popup say?

EDIT: Actually I have several questions, starting with what did the error popup say?

Which version of darktable? Were any other scripts running? Did you start OpenInExplorer from script_manager?

What patch level of Win10?

Did you try troubleshooting lib/darktable_transition.lua?

This works fine on Linux. I'll test on Win7, which is what I have available and see if the problem is there also.

wpferguson commented 3 years ago

Tested on win7 and it works fine with 3.4.0 and latest pull from the lua-scripts repository.

carthurs commented 3 years ago

Whoops, I was actually a couple of days out of date with the origin repo: I was working from https://github.com/darktable-org/lua-scripts/commit/ade7008127f1a4ca860d6838f708a19e5856c906 (which is where I saw the errors).

From the latest tree, I don't see the error any more from this commit yesterday: https://github.com/darktable-org/lua-scripts/commit/b1498aa664a550e274cdc797e30ed56456379e4e

For completeness, DT v. 3.4.0, Win10 v 1909 build 18363.1316. The popup error was contrib/OpenInExplorer failed to load, and the log contained this:

395.791831 LUA ERROR: script_manager.lua: activate: 208: Error loading contrib/OpenInExplorer 
395.792832 LUA ERROR: script_manager.lua: activate: 209: Error message: ...h\AppData\Local\darktable/lua/contrib/OpenInExplorer.lua:213: bad argument #1 to 'register_event' (string expected, got boolean)

Some hurried copy-pasting between two repos on my machine is the reason the PR is not based at the place you'd expect. Apologies for that one - I made it work late last night & wanted to share before bed in case others were stuck! Feel free to close...