search

darktable-org / lua-scripts

155 stars 110 forks source link

Sanitize strings in Windows command calls #436

Closed wpferguson closed 4 months ago

wpferguson commented 9 months ago

Handle command execution with for commands that require multiple quoted strings on Windows. This handles circumstances such as:

See https://github.com/darktable-org/darktable/pull/15437 for more information.

The scripts that need fixed are:

JAVIBARAKA commented 2 months ago

42d391f4b0c2aae6fa033ccf01346bdf9c401035 jpg

Sigo con el problema. He descargado la última versión de darktable y, no sé como solucionarlo.

wpferguson commented 2 months ago

https://github.com/darktable-org/lua-scripts/issues/492

JAVIBARAKA commented 2 months ago

492

No sé exactamente lo que tengo que hacer ni desde donde. Podía alguien indicarme donde tengo que entrar y que parámetros tengo que cambiar, etc. Gracias.

wpferguson commented 2 months ago

The scripts should just update automatically unless you have turned off check for updated scripts on startup.

JAVIBARAKA commented 2 months ago

No recuerdo haber hecho nada de eso pero veo que los problemas que tengo, los está teniendo más gente. De todas formas, agradeceréme indiques como puedo comprobar la actualización de scripts. En martes, 16 de julio de 2024, 23:27:35 CEST, wpferguson @.***> escribió:

The scripts should just update automatically unless you have turned off check for updated scripts on startup.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

wpferguson commented 2 months ago

The fixes I'm doing affect the lua-scripts on darktable 4.8.x. Some fixes might get back ported to 4.6.x. You are on 4.4.x.

Have you thought of upgrading? The issue may already be fixed.

JAVIBARAKA commented 2 months ago

Tengo instalada ya la versión 4.8 de darktable. Sigo teniendo el problema.

------ Mensaje original ------ De "wpferguson" @.> Para "darktable-org/lua-scripts" @.> Cc "JAVIBARAKA" @.>; "Comment" @.> Fecha 17/07/2024 16:22:02 Asunto Re: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

The fixes I'm doing affect the lua-scripts on darktable 4.8.x. Some fixes might get back ported to 4.6.x. You are on 4.4.x.

Have you thought of upgrading? The issue may already be fixed.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/lua-scripts/issues/436#issuecomment-2233451301, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD6FJBA6OFVILQZFKFNRZDZMZ4YVAVCNFSM6AAAAABI5EBK6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGQ2TCMZQGE. You are receiving this because you commented.Message ID: @.***>

-- Este correo electrónico ha sido analizado en busca de virus por el software antivirus de Avast. www.avast.com

JAVIBARAKA commented 2 months ago

Otro de los problemas.

------ Mensaje original ------ De "FranciscoJavier" @.> Para "darktable-org/lua-scripts" @.> Fecha 17/07/2024 18:58:13 Asunto Re[2]: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

Tengo instalada ya la versión 4.8 de darktable. Sigo teniendo el problema.

------ Mensaje original ------ De "wpferguson" @.> Para "darktable-org/lua-scripts" @.> Cc "JAVIBARAKA" @.>; "Comment" @.> Fecha 17/07/2024 16:22:02 Asunto Re: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

The fixes I'm doing affect the lua-scripts on darktable 4.8.x. Some fixes might get back ported to 4.6.x. You are on 4.4.x.

Have you thought of upgrading? The issue may already be fixed.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/lua-scripts/issues/436#issuecomment-2233451301, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD6FJBA6OFVILQZFKFNRZDZMZ4YVAVCNFSM6AAAAABI5EBK6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGQ2TCMZQGE. You are receiving this because you commented.Message ID: @.***>

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient Libre de virus.www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

-- Este correo electrónico ha sido analizado en busca de virus por el software antivirus de Avast. www.avast.com

wpferguson commented 2 months ago

Open a new issue describing your problem or problems. I need the following information:

JAVIBARAKA commented 2 months ago

Darktable v 4.8.0 Windows 10

Mi nombre de usuario es: Francisco Javier

C:\Users\Propietario\AppData\Local\darktable>

Cuando edito una imagen y la quiero exportar a collection para su posterior edición en otro software me da error. Varios de los scripts NO funcionan. check_for_updates por ejemplo La carpeta lua-cjson donde debe ir ubicada para su funcionamiento?

------ Mensaje original ------ De "wpferguson" @.> Para "darktable-org/lua-scripts" @.> Cc "JAVIBARAKA" @.>; "Comment" @.> Fecha 17/07/2024 19:14:38 Asunto Re: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

Open a new issue describing your problem or problems. I need the following information:

darktable version operating system and version a list of steps to make the problem occur does your username or the paths to the files have any special characters or spaces in them? — Reply to this email directly, view it on GitHub https://github.com/darktable-org/lua-scripts/issues/436#issuecomment-2233802576, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD6FJDOIVHQSLZDONU2CNTZM2Q75AVCNFSM6AAAAABI5EBK6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTHAYDENJXGY. You are receiving this because you commented.Message ID: @.***>

-- Este correo electrónico ha sido analizado en busca de virus por el software antivirus de Avast. www.avast.com

JAVIBARAKA commented 2 months ago

Estos son errores que me da.

------ Mensaje original ------ De "FranciscoJavier" @.> Para "darktable-org/lua-scripts" @.> Fecha 17/07/2024 23:27:13 Asunto Re[2]: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

Darktable v 4.8.0 Windows 10

Mi nombre de usuario es: Francisco Javier

C:\Users\Propietario\AppData\Local\darktable>

Cuando edito una imagen y la quiero exportar a collection para su posterior edición en otro software me da error. Varios de los scripts NO funcionan. check_for_updates por ejemplo La carpeta lua-cjson donde debe ir ubicada para su funcionamiento?

------ Mensaje original ------ De "wpferguson" @.> Para "darktable-org/lua-scripts" @.> Cc "JAVIBARAKA" @.>; "Comment" @.> Fecha 17/07/2024 19:14:38 Asunto Re: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

Open a new issue describing your problem or problems. I need the following information:

darktable version operating system and version a list of steps to make the problem occur does your username or the paths to the files have any special characters or spaces in them? — Reply to this email directly, view it on GitHub https://github.com/darktable-org/lua-scripts/issues/436#issuecomment-2233802576, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD6FJDOIVHQSLZDONU2CNTZM2Q75AVCNFSM6AAAAABI5EBK6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTHAYDENJXGY. You are receiving this because you commented.Message ID: @.***>

https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient Libre de virus.www.avast.com https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=emailclient <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

-- Este correo electrónico ha sido analizado en busca de virus por el software antivirus de Avast. www.avast.com

wpferguson commented 2 months ago

Check for updates requires other packages as stated here: https://docs.darktable.org/lua/stable/lua.scripts.manual/scripts/official/check_for_updates/. luasec has some source code requirements and has to be compiled, so I'm not sure you can satisfy the prerequisites.

Can you run darktable in a command prompt with the following command:

C:\Program Files\darktable\bin\darktable.exe" -d lua

This will write any error messages to the file %LOCALAPPDATA%\Microsoft\Windows\InetCache\darktable\darktable-log.txt.

Run the scripts that are having problems, quit darktable, then attach the file so that I can try and determine with the problem is.

JAVIBARAKA commented 2 months ago

Siguiendo las instrucciones del enlace  darktable lua documentation - check_for_updates

darktable lua documentation - check_for_updates

|

|

|

enviado descargue lua-cjson pero no sé donde debo ubicar la carpeta. Respecto a C:\Program Files\darktable\bin\darktable.exe" -d lua puedo abrirlo desde aquí sin ningún problema. En jueves, 18 de julio de 2024, 02:20:06 CEST, wpferguson @.***> escribió:

Check for updates requires other packages as stated here: https://docs.darktable.org/lua/stable/lua.scripts.manual/scripts/official/check_for_updates/. luasec has some source code requirements and has to be compiled, so I'm not sure you can satisfy the prerequisites.

Can you run darktable in a command prompt with the following command:

C:\Program Files\darktable\bin\darktable.exe" -d lua

This will write any error messages to the file %LOCALAPPDATA%\Microsoft\Windows\InetCache\darktable\darktable-log.txt.

Run the scripts that are having problems, quit darktable, then attach the file so that I can try and determine with the problem is.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

JAVIBARAKA commented 2 months ago

Te envío el archivo generado desde
%LOCALAPPDATA%\Microsoft\Windows\InetCache\darktable\darktable-log.txt

------ Mensaje original ------ De "wpferguson" @.> Para "darktable-org/lua-scripts" @.> Cc "JAVIBARAKA" @.>; "Comment" @.> Fecha 18/07/2024 2:20:05 Asunto Re: [darktable-org/lua-scripts] Sanitize strings in Windows command calls (Issue #436)

Check for updates requires other packages as stated here: https://docs.darktable.org/lua/stable/lua.scripts.manual/scripts/official/check_for_updates/. luasec has some source code requirements and has to be compiled, so I'm not sure you can satisfy the prerequisites.

Can you run darktable in a command prompt with the following command:

C:\Program Files\darktable\bin\darktable.exe" -d lua

This will write any error messages to the file %LOCALAPPDATA%\Microsoft\Windows\InetCache\darktable\darktable-log.txt.

Run the scripts that are having problems, quit darktable, then attach the file so that I can try and determine with the problem is.

— Reply to this email directly, view it on GitHub https://github.com/darktable-org/lua-scripts/issues/436#issuecomment-2234869030, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALD6FJDNYBUORRX7EC4DSBLZM4C3LAVCNFSM6AAAAABI5EBK6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZUHA3DSMBTGA. You are receiving this because you commented.Message ID: @.***>

-- Este correo electrónico ha sido analizado en busca de virus por el software antivirus de Avast. www.avast.com

version: darktable 4.8.0 start: 2024:07:18 18:01:43

El sistema no puede encontrar la ruta especificada. El sistema no puede encontrar la ruta especificada.

end: 2024:07:18 18:01:43

======================================== version: darktable 4.8.0 start: 2024:07:18 18:09:39

darktable 4.8.0 Copyright (C) 2012-2024 Johannes Hanika and other contributors.

Compile options: Bit depth -> 64 bit Debug -> DISABLED SSE2 optimizations -> ENABLED OpenMP -> ENABLED OpenCL -> ENABLED Lua -> ENABLED - API version 9.3.0 Colord -> DISABLED gPhoto2 -> ENABLED GMIC -> ENABLED - Compressed LUTs are supported GraphicsMagick -> ENABLED ImageMagick -> DISABLED libavif -> ENABLED libheif -> ENABLED libjxl -> ENABLED OpenJPEG -> ENABLED OpenEXR -> ENABLED WebP -> ENABLED

See https://www.darktable.org/resources/ for detailed documentation. See https://github.com/darktable-org/darktable/issues/new/choose to report bugs.

 4.8333 LUA DEBUG: script_manager.lua: get_current_repo_branch: 272: branch for testing is * master 
 4.8335 LUA INFO: script_manager.lua:  current repo branch is master 
 4.8337 LUA INFO: script_manager.lua:  repo is clean 
 5.8854 LUA DEBUG: script_manager.lua: get_repo_branches: 300: data is

Already up to date.

wpferguson commented 2 months ago

Could you try again. I turned off debug messages in script_manager, so hopefully I'll see the messages that let me know what the problem is.

JAVIBARAKA commented 2 months ago

Editar darktable-log.txt Collection Lo he intentado y todo sigue igual. Además hay scripts que no funcionan.

JAVIBARAKA commented 2 months ago

Descargué la nueva versión de darktable. Hice pruebas para ver si el problema se había solucionado pero, sigue igual, incluso descargué gimp y al querer editar con el mismo, tampoco funcionaba.

JAVIBARAKA commented 1 month ago

¿Hay alguna solución a este problema?.

wpferguson commented 1 month ago

This issue is closed. Please open a new issue.

JAVIBARAKA commented 1 month ago

El problema es el mismo. Darktable me sigue fallando a la hora de exportar a editor externo y, no sé los pasos a dar para solucionarlo. No tengo conocimientos de programación. En jueves, 5 de septiembre de 2024, 02:57:44 CEST, wpferguson @.***> escribió:

This issue is closed. Please open a new issue.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>