tools/script_manager - fixed crash

[mime01]

The script manager crashes if a LUA script was not copied to a subfolder but directly into the LUA directory. The reason is that the regular expression, which among other things extracts the category of the script from its file path, does not match and thus the category is null. To prevent this, a null check has been added.

[wpferguson]

The fix works and solves the crashing problem.

What I'm wondering is what the "correct" way to handle this is.

Do we

• ignore the script because it's not in folder (what the fix does)
• should we assign it a category ("local" or "unbundled"?) and then ignore the category when we start the script
• if we just ignore it, should we pop a toast message to let the use know we saw the script but didn't include it in script_manager
• if we decide to include it, then we should probably add a toast message saying what we did.

Thoughts?

[mime01]

I also thought about adding the script with a no category placeholder (or similar), but then decided to go with the simplest fix so that at least the script manager does not disappear, which is very confusing. But I agree that there is room for improvement.

I came across this when I was going through the example sharing scripts in the documentation, where the script is started directly from the luarc file. In this case, it was not important for the script to be shown in the script manager.

[wpferguson]

I think I'll go with just the patch. The only way a script can can be in the root folder is if the user puts it there. so they should know.