search

darktable-org / rawspeed

fast raw decoding library
GNU Lesser General Public License v2.1
355 stars 113 forks source link

question: Difference for embedded lens-correction for OM-System Mark II between DNG and ORF #712

Closed astmuc closed 5 months ago

astmuc commented 5 months ago

I can see the automatic lens correction using embedded info if the input is DNG. But i see no lens correction for the native ORF format.

Is this an effect of https://github.com/darktable-org/rawspeed/issues/686, or is it maybe simply an unsupported feature ?

kmilos commented 5 months ago

Lens correction is out of scope for the RawSpeed library.

Please seek support at https://discuss.pixls.us/c/software/darktable/19 or https://github.com/darktable-org/darktable/issues

kmilos commented 5 months ago

Is this an effect of...

It is not.

LebedevRI commented 5 months ago

None of the lens correction opcodes are supported by rawspeed: https://github.com/darktable-org/rawspeed/blob/bd2b74eb46446924a8f5b15f58fdad18a6f6e3d3/src/librawspeed/common/DngOpcodes.cpp#L748-L754 https://github.com/darktable-org/rawspeed/blob/bd2b74eb46446924a8f5b15f58fdad18a6f6e3d3/src/librawspeed/common/DngOpcodes.cpp#L771-L772 so @kmilos is correct.