search

darktable-org / rawspeed

fast raw decoding library
GNU Lesser General Public License v2.1
355 stars 113 forks source link

Remove "no-samples" for Fujifilm FinePix S9600fd #731

Closed victoryforce closed 3 months ago

victoryforce commented 3 months ago

S9600fd is just S9600 with face detection (and for S9600 we have a sample in RPU). In the Fujifilm model line, there were several cases of models being released without and with the fd suffix. Such models are identical in everything else except for the presence of face detection code in the camera firmware.

So we can avoid annoying the user with "no-samples" warnings for S9600fd.

victoryforce commented 3 months ago

First, if that is a standalone camera entry, it must have samples.

Second, clearly we aren't bothering them enough since there's still no RPU sample for S9600fd in review queue. /s

This camera is almost two decades old, so we shouldn't expect many darktable users to process images from this camera. And this makes it very unlikely that we will ever see samples from this particular camera model. :(

Thirdly, if this is the exact same camera, it's whole <Camera> should be

      <Aliases>
          <Alias id="FinePix S9600fd">Fujifilm FinePix S9600fd</Alias>
      </Aliases>

in <Camera> for S9600. I think that will also silence that begging too.

I agree. The xml entries for these two cameras are identical, so the replacement to Alias was a natural choice. I simply chose the fix that made the least change to the current data. Changed.

LebedevRI commented 3 months ago

@victoryforce thank you!