search

darktrojan / betterimageviewer

Better Image Viewer for Firefox
https://addons.mozilla.org/firefox/addon/better-image-viewer/
19 stars 3 forks source link

fix: replace `document.body.scrollTo` method #20

Closed aarrwnh closed 2 years ago

aarrwnh commented 2 years ago

Per bug1724243 images are now rendered in a "standards-mode" instead of "quirks-mode" which makes document.body.scrollTo method not work with how image is displayed according to CSS rules (i.e. document's box model height is 0px).

Resolves:

18

19

darktrojan commented 2 years ago

Thanks for the fix. Can I suggest that in future you don't reformat the code? It makes it much more difficult to see what actually changed, and therefore less likely your changes will be accepted.

aarrwnh commented 2 years ago

@darktrojan That was auto-format since case clauses were/are not indented correctly.

Yes, I know I should not reformat code where it's not necessary, but the changes didn't looked that difficult and in the 'diff view' there's a 'hide whitespace' option, which minimizes edit clutter -- hence why I didn't revert it.