first version of the shortcut features

darktrojan / openwith

Open With add-on for Firefox

https://addons.mozilla.org/addon/open-with/

412 stars 71 forks source link

first version of the shortcut features #179

Closed dummys closed 6 years ago

dummys commented 7 years ago

Hi, I opened this pull request to ask you if such idea will be interesting for the project. My idea was to add options to change this default keyboard shortcut. The function to validate correct shortcut take some times because we need to validate shortcut against Key combinations from webextension command rules.

I will add other commit regarding the options.

darktrojan commented 6 years ago

That's pretty much what I'd do, but I had a few changes in mind, so I just did it in 6a1fa1e89369a61dda387141c0001cfb9554f25b. My changes would destroy just about every line of yours (sorry), so I didn't pull this first. Thanks anyway!