Add support for Brave Browser and Waterfox Current

darktrojan / openwith

Open With add-on for Firefox

https://addons.mozilla.org/addon/open-with/

412 stars 71 forks source link

Add support for Brave Browser and Waterfox Current #260

Open grahamperrin opened 4 years ago

grahamperrin commented 4 years ago

Fixes #250 (hopefully).

This draft PR will almost certainly require corrections to code from people who are familiar with:

Brave Browser
Waterfox Current

– on:

Linux
macOS
Windows.

The commits here are based upon the patch with which @sawyer07 opened #250.

Please note:

I'm not a developer
my everyday OS is FreeBSD-CURRENT, there's no port of Brave Browser or Waterfox Current
I don't have a Mac on which to test

– and so on, so there's guesswork by me in all three of the files.

sebma commented 4 years ago

@grahamperrin Hi, I tried your modifications from your 7510cb2 commit, but it didn't do anything.

I had to replace Brave-Browser-Dev by Brave-Browser for the script to work :

$ ls -ld ~/.config/BraveSoftware/Brave-Browser-Dev
ls: cannot access /home/abcdxyzt/.config/BraveSoftware/Brave-Browser-Dev: No such file or directory
$ ls -ld ~/.config/BraveSoftware/Brave-Browser
drwx------ 1 abcdxyzt abcdxyzt 1056 mars  14 02:36 /home/abcdxyzt/.config/BraveSoftware/Brave-Browser/

DeltaForCain commented 4 years ago

I found a way to make it work with Waterfox on Windows:

open open_with_windows.py with an editor
edit line 78: Where it says Firefox, enter Waterfox (two entries here)
edit line 83: same as above, change from Firefox to Waterfox

Save, run as instructed, it should now work.

grahamperrin commented 3 years ago

(This fell off my radar a few months ago, sorry. All suggestions/fixes welcome.)