search

darkvoid-theme / darkvoid.nvim

Neovim Colorscheme for dark dwellers with optional glow effect!
MIT License
144 stars 9 forks source link

Colorscheme does not work well if it is not the only colorscheme installed #6

Closed gustavkrist closed 1 month ago

gustavkrist commented 1 month ago

I like this colorscheme, but I tend to switch between colorschemes and unlike every other colorscheme I have installed, this one only seems to work properly if it is used as the only colorscheme. Other colorschemes only extend the config when their setup method is called and then apply them when the colorscheme is loaded using colorscheme <name>, which allows adding multiple colorschemes to for example a lazy plugin spec and setting them all up. Calling colorscheme darkvoid after another colorscheme has been set also does not work proplerly as highlights are not cleared when darkvoid is applied. I made a small fix for these issued so that I could use the colorscheme and have opened a PR https://github.com/Aliqyan-21/darkvoid.nvim/pull/7, as I think this would benefit more people.

Aliqyan-21 commented 1 month ago

Hello @gustavkrist, thanks for finding this bug and fixing this issue, I have merged your PR as it makes the colorscheme more flexible and helps for the seamless transition between different colorschemes!