search

darkwallet / python-obelisk

Pure Python Obelisk + Bitcoin client side library
GNU Affero General Public License v3.0
62 stars 50 forks source link

python-ecdsa breaks compatibility #21

Closed abitfan closed 9 years ago

abitfan commented 9 years ago

The latest release of python-ecdsa warner/python-ecdsa@80bdce1c0dd8d82134a7eda887cd7a54f7548d81 changed the number of arguments for ecdsa.curves.Curve which is used in https://github.com/darkwallet/python-obelisk/blob/master/obelisk/bitcoin.py line 315 I was going to re-write the code to check for ecdsa package version and change the number of arguments accordantly, but I thought I'd check here first.

Thoughts ?

hoffmabc commented 9 years ago

Yeah just found this out as well. I just submitted a PR upstream for this.

https://github.com/darkwallet/python-obelisk/pull/22

veox commented 9 years ago

Since it's fixed upstream, and the related PR is closed, this can be closed as well.