search

darlal / obsidian-switcher-plus

Enhanced Quick Switcher plugin for Obsidian.md
GNU General Public License v3.0
418 stars 11 forks source link

Incompatible with Obsidian v1.7.2 #177

Open liamcain opened 1 week ago

liamcain commented 1 week ago

Hi! We just made some API changes in Obsidian 1.7.2 and this plugin was impacted. We removed PreparedQuery and fuzzySearch in favor of the newer API prepareFuzzySearch.

There are some more details about the change here.

If I have time later today, I'll try to submit a pull request with the needed fixes. Sorry for the disruption!

darlal commented 1 week ago

Hey @liamcain! It's been a long time 🙂 Thanks for the head's up.

I guess I didn't realize that those functions had been deprecated. I imagine that change will cause a lot of test failures, PRs welcomed! I likely won't have any cycles to devote to it until the weekend at the earliest, so if you don't get to it, I'll pull one together over the weekend. Thanks!

liamcain commented 1 week ago

Okay, I just checked and while we removed fuzzySearch and prepareFuzzySearch from the API spec, they are still exported from Obsidian, so thankfully nothing is broken currently. I took at stab at trying to refactor the plugin but PreparedQuery gets passed around a lot more than I expected 😅.

Not to mention all those pesky unit tests lol

darlal commented 1 week ago

Ok, thanks for the update. Yea, those functions are pretty pervasive, I'm starting the upgrade now. Thanks!