Closed CuriousTommy closed 4 years ago
But this would mean that people who do have SSH set up (as you should have) would have to input their credentials each time when pushing changes.
Actually the patch changes to a relative URL, so it will be either HTTPS or SSH depending on what you use already — not unconditional HTTPS. Good.
so it will be either HTTPS or SSH depending on what you use already
Oh! I didn't know that.
Good.
Would this be fine to merge? I can change the commit message if you want me to.
I'm fine with it (with commit message changed), but it'll leave it for somebody else to ack and merge
For people who don't have ssh set up for GitHub, you will get the error below. Using HTTPS will avoid this error.