gitmodules: Use Relative URL instead of Only SSH

darlinghq / darling-corecrypto

CoreCrypto reimplementation under GPL-3

http://www.darlinghq.org

GNU General Public License v3.0

23 stars 9 forks source link

Closed CuriousTommy closed 4 years ago

CuriousTommy commented 4 years ago

For people who don't have ssh set up for GitHub, you will get the error below. Using HTTPS will avoid this error.

The authenticity of host 'github.com (...)' can't be established.
RSA key fingerprint is ...
Are you sure you want to continue connecting (yes/no)?

bugaevc commented 4 years ago

But this would mean that people who do have SSH set up (as you should have) would have to input their credentials each time when pushing changes.

bugaevc commented 4 years ago

Actually the patch changes to a relative URL, so it will be either HTTPS or SSH depending on what you use already — not unconditional HTTPS. Good.

CuriousTommy commented 4 years ago

so it will be either HTTPS or SSH depending on what you use already

Oh! I didn't know that.

Good.

Would this be fine to merge? I can change the commit message if you want me to.

bugaevc commented 4 years ago

I'm fine with it (with commit message changed), but it'll leave it for somebody else to ack and merge