darlinghq / darling-corecrypto

CoreCrypto reimplementation under GPL-3
http://www.darlinghq.org
GNU General Public License v3.0
23 stars 9 forks source link

feat: Implement basic DES #9

Closed trungnt2910 closed 2 years ago

trungnt2910 commented 2 years ago

Replaced DES and 3DES stubs with DES implementation from libtomcrypt (licensed under The Unlicense).

Required to get dotnet running for the first time.

facekapow commented 2 years ago

Almost LGTM; since you used code from libtomcrypt, it'd be nice if you could add a comment somewhere in the file (preferably at the top) crediting them (even if the code is under The Unlicense).

Let me run some tests and add some test cases, but all the code itself looks fine.