search

darlinghq / darling-dmg

FUSE module for .dmg files (containing an HFS+ filesystem)
http://www.darlinghq.org
GNU General Public License v3.0
273 stars 45 forks source link

Incorrect assert that prevent decompress. #79

Closed jief666 closed 6 years ago

jief666 commented 6 years ago

Regarding #78

assert(bytesDecompressed == to_read) is incorrect. It does happen. Next call complete the buffer so no problem to remove that.

Fixed also some debug messages that prevent compilation with DEBUG

tomkoen commented 6 years ago

@jief666 Unfortunately, it didn't fix https://github.com/darlinghq/darling-dmg/issues/78

jief666 commented 6 years ago

PR #80 and #81 will fix it all. When I did this little modification, the dmg could mount. That's why I did the PR. It's only when I did a "deeper" test that I realise that there were missing files, leading to the bug #80 (a not so easy one to track) which is not link at all to compression. Then, when file reappeared, I saw that there were still decompression error. To test before @LubosD merge the 2 PR, you can clone my branch stat_bug (https://github.com/jief666/darling-dmg/tree/stat_bug) and then copy paste DMGDecompressor.cpp from the branch bz_lib_alog (https://github.com/jief666/darling-dmg/tree/bz_zlib_alog).