Because if we are in a case where both Apple is defined and DARLING is not, then, we won't have the position variable defined, and it will crash at build time showing that error :
/workdir/darling/src/external/darling-dmg/src/main-fuse.cpp:287:6: error: use of undeclared identifier 'position'
Should I open a PR for this, or is someone else can fix it ?
Hi Everyone,
https://github.com/darlinghq/darling-dmg/blob/97a92a6930e43cdbc9dedaee62716e3223deb027/src/main-fuse.cpp#L287
Basically we should have in line 286 :
if defined(APPLE) && !defined(DARLING)
And not like now only :
if defined(APPLE)
Because if we are in a case where both Apple is defined and DARLING is not, then, we won't have the position variable defined, and it will crash at build time showing that error :
/workdir/darling/src/external/darling-dmg/src/main-fuse.cpp:287:6: error: use of undeclared identifier 'position'
Should I open a PR for this, or is someone else can fix it ?
Thanks :)
Eliel