Fix paths for FreeBSD - Githubissues

Martinfx commented 5 years ago

Hi, i compiled code on FreeBSD but i had problem with directory includes and directory libs fatal error: 'unicode/unistr.h' file not found #include <unicode/unistr.h> patch for path for includes and libs

bugaevc commented 5 years ago

there are unrelated changes in the patch
can't you pass /usr/local paths to CMake, well, locally? why it needs to be something hardcoded upstream?

Martinfx commented 5 years ago

I made locally patch for port to freshports

Martinfx commented 5 years ago

thx

probonopd commented 2 years ago

Please reopen.

Currently it does not compile on FreeBSD:

FreeBSD% LANG=C make    
Consolidate compiler generated dependencies of target dmg
[  3%] Building CXX object CMakeFiles/dmg.dir/src/unichar.cpp.o
/tmp/darling-dmg/src/unichar.cpp:3:10: fatal error: 'unicode/unistr.h' file not found
#include <unicode/unistr.h>
         ^~~~~~~~~~~~~~~~~~
1 error generated.                                                                               
make[2]: *** [CMakeFiles/dmg.dir/build.make:76: CMakeFiles/dmg.dir/src/unichar.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/dmg.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

A working solution has been proposed but has never been merged: https://github.com/darlinghq/darling-dmg/pull/94/files

Could this please be reopened an merged?

To test:

wget --trust-server-names "https://download.mozilla.org/?product=firefox-latest-ssl&os=osx&lang=en-US"
./darling-dmg ./Firefox*.dmg /mnt
ls /mnt
# Firefox.app

Works!

Also @Martinfx do you think you could make a FreeBSD Port and get it into the official FreeBSD Ports collection?

Reference:

https://github.com/helloSystem/ISO/issues/280

Martinfx commented 2 years ago

Please reopen.

Currently it does not compile on FreeBSD:

FreeBSD% LANG=C make    
Consolidate compiler generated dependencies of target dmg
[  3%] Building CXX object CMakeFiles/dmg.dir/src/unichar.cpp.o
/tmp/darling-dmg/src/unichar.cpp:3:10: fatal error: 'unicode/unistr.h' file not found
#include <unicode/unistr.h>
         ^~~~~~~~~~~~~~~~~~
1 error generated.                                                                               
make[2]: *** [CMakeFiles/dmg.dir/build.make:76: CMakeFiles/dmg.dir/src/unichar.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:85: CMakeFiles/dmg.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

A working solution has been proposed but has never been merged: https://github.com/darlinghq/darling-dmg/pull/94/files

Could this please be reopened an merged?

To test:

wget --trust-server-names "https://download.mozilla.org/?product=firefox-latest-ssl&os=osx&lang=en-US"
./darling-dmg ./Firefox*.dmg /mnt
ls /mnt
# Firefox.app

Works!

Also @Martinfx do you think you could make a FreeBSD Port and get it into the official FreeBSD Ports collection?

Reference:

* [Support .dmg disk images helloSystem/ISO#280](https://github.com/helloSystem/ISO/issues/280)

I have complete port from since 2019 darling-dmg I could open Bugzilla request

probonopd commented 2 years ago

I could open Bugzilla request

Please do! :)

Still, I think if this can be fixed upstream (= here) it's better than in a FreeBSD Ports patch.

Martinfx commented 2 years ago

I could open Bugzilla request

Please do! :)

Still, I think if this can be fixed upstream (= here) it's better than in a FreeBSD Ports patch.

He wants not my patch so they will in my github or FreeBSD ports patch

probonopd commented 2 years ago

OK, so let's have the patch in FreeBSD Ports then :)

Martinfx commented 2 years ago

OK, so let's have the patch in FreeBSD Ports then :)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267207 https://github.com/Martinfx/FreeBSD-Ports/pull/84/files

darlinghq / darling-dmg

Fix paths for FreeBSD #94