darlingm / vim

Automatically exported from code.google.com/p/vim
0 stars 0 forks source link

HTML script tag syntax highlight overextends on some html #289

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enter valid HTML, with a script tag in the head
2. Type javascript inside the script tag
3. End the script tag with a valid (but unusual) </script > tag. The space is 
the issue.

What is the expected output? What do you see instead?
The javascript highlighting should stop at the end script tag. Instead, syntax 
highlighting continues into the HTML document.

What version of the product are you using? On what operating system?
Vim74, Ubuntu 14.04

Please provide any additional information below.
Line 171;196 can be changed in /runtime/syntax/html.vim to say 
..."end=+</script\_[^>]*>+me=s-1"... rather than ..."end=+</script>+me=s-1"... 
to fix this issue. 

Original issue reported on code.google.com by Felix.Da...@gmail.com on 28 Nov 2014 at 11:47

GoogleCodeExporter commented 9 years ago
You should take your changes to the maintainer of the file. If he includes your 
changes, he will send updated runtime files for inclusion with Vim to Bram. If 
the maintainer seems to be unreachable or inactive, you can send your changes 
directly to Bram (or better vim-dev mailinglist for review) for inclusion. 

Original comment by chrisbr...@googlemail.com on 29 Nov 2014 at 12:06

GoogleCodeExporter commented 9 years ago
Thanks. I just emailed Claudio, the maintainer on the html.vim syntax file. 
I'll attach the patch I sent him here just for completeness.

Original comment by Felix.Da...@gmail.com on 29 Nov 2014 at 4:37

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed with latest runtime files 
(https://code.google.com/p/vim/source/detail?r=11d78e58a487471e13ecb5223b75249cd
7e949d5)

Original comment by chrisbr...@googlemail.com on 9 Jan 2015 at 12:06