search

darmuh / suitsTerminal

suitsTerminal for Lethal Company
https://thunderstore.io/c/lethal-company/p/darmuh/suitsTerminal/
MIT License
1 stars 1 forks source link

[vanilla compatibility issue] if custom number of suits in rack or anything about remove suits in rack, will cause player can't join vanilla lobby #9

Closed CoolLKKPS closed 1 week ago

CoolLKKPS commented 2 months ago

@darmuh and u also messed up the sequence of the suits, which caused the name of suits to not match their own, u should keep vanilla behavior or just like toomanysuit to keep the suits in sync Note: host need to switch suit page to page 1, to make the client can sync suits correctly

darmuh commented 2 months ago

@darmuh and u also messed up the sequence of the suits, which caused the name of suits to not match their own, u should keep vanilla behavior or just like toomanysuit to keep the suits in sync Note: host need to switch suit page to page 1, to make the client can sync suits correctly

Could you further explain what you mean by vanilla compatibility? When are you using this mod in vanilla lobbies? As far as i'm aware all players need to have the same suits for you to be able to see eachother's suits.

Also, per your request I've added different sorting options including "none" which will not apply any sorting. This is in the latest update, 1.2.0

CoolLKKPS commented 2 months ago

so the thing is, if the suits data are not synced, u will receive error and cannot join the lobby, so suitsTerminal did remove suits to keep the rack clean, but which make u cannot join other people lobby due suits data de-sync, and break vanilla compatibility, so ok u can try by urself, im sure this is 100% can reproduce (i didn't check recently update during this day/night)

darmuh commented 2 months ago

so the thing is, if the suits data are not synced, u will receive error and cannot join the lobby, so suitsTerminal did remove suits to keep the rack clean, but which make u cannot join other people lobby due suits data de-sync, and break vanilla compatibility, so ok u can try by urself, im sure this is 100% can reproduce (i didn't check recently update during this day/night)

https://github.com/darmuh/suitsTerminal/assets/152580271/a9cee8b5-7829-4456-90cb-00ad269c8a9b

perhaps it was an issue with earlier versions, here's a clip of me joining a vanilla lobby with the rack completely removed on my own game. No issues from what I can see

CoolLKKPS commented 2 months ago

will keep tracking this issue!

CoolLKKPS commented 2 months ago

@darmuh ok another issue now image

i installed toomanysuit so not sure if this was a conflict issue, but as u can see, i select a suit, but switch to default suit right after when i click enter

CoolLKKPS commented 2 months ago

@darmuh

  1. additional: only affect the first 3 suits in my case bc i have 15 suits
  2. if use lobbycontrol to hot-load a save, suits will disappear on the rack
  3. tested removing suits on the rack now won't affect MoreCompany clients, they can join the lobby with suitsTerminal
CoolLKKPS commented 2 months ago

still can do better, but good job!

darmuh commented 2 months ago

@darmuh

  1. additional: only affect the first 3 suits in my case bc i have 15 suits
  2. if use lobbycontrol to hot-load a save, suits will disappear on the rack
  3. tested removing suits on the rack now won't affect MoreCompany clients, they can join the lobby with suitsTerminal

Are these still issues? Sorry I havent had much time to look here. I'd prefer to keep any active issues open if they are still issues. Regarding toomanysuits, I'm wondering if it's an issue with toomanysuits' rack refresh feature? I have learned recently that toomanysuits requires all clients to have the mod and syncs between host/client

CoolLKKPS commented 2 months ago

no should be more conflict that u think, u better test that by ur own bc that's all i can tell