daroczig / binancer

An R client to the Public Rest API for Binance.
https://daroczig.github.io/binancer
54 stars 57 forks source link

Usdm support #22

Open siegfried opened 2 years ago

siegfried commented 2 years ago

This PR is related to #22

siegfried commented 2 years ago

I'm a little hesitant to modify the current code base even through a few of them are reusable. I presume to reuse them some renaming and updates might be necessary, so I think adding some tests at first might be a good idea, in order to not break current behavior. This is a WIP PR, so please feel free to leave any comment. @daroczig

siegfried commented 2 years ago

These functions are using deprecated V1 API. Is there a plan to remove them in favor of V3?

Also these functions which are fundamental should be migrated easily:

@daroczig

siegfried commented 2 years ago

Or shall we version the functions according to the API?

siegfried commented 2 years ago

On a second thoughts we might have to skip the tests requiring authentication until it is possible to have a shared credential for testing. Even though the timestamp can be input as an argument. different credentials would produce different signatures.

siegfried commented 2 years ago

If you feel I'm heading to the right direction, you can merge this PR. I'll add the missing feature one by one. @daroczig

siegfried commented 2 years ago

May I use packages from tidyverse in this package?

siegfried commented 2 years ago

Now LIMIT orders and MARKET orders work on USDM.