daroczig / binancer

An R client to the Public Rest API for Binance.
https://daroczig.github.io/binancer
54 stars 57 forks source link

binance_new_order MARKET_LOT_SIZE often 0 which causes order to fail #25

Open imprompt opened 1 year ago

imprompt commented 1 year ago

Market orders fail because the stepSize in MARKET_LOT_SIZE is often 0 (e.g. EOSUSDT). I think there probably needs to be a check to make sure it's non-zero before applying the precision check for quantity in market orders.

imprompt commented 1 year ago

It looks like MARKET_LOT_SIZE is additional requirements for market orders on top of LOT_SIZE: https://dev.binance.vision/t/which-symbol-filter-is-used-with-a-market-order/426 Therefore the LOT_SIZE stepSize check could be applied first and the MARKET_LOT_SIZE stepSize check applied only if it's > 0.