Error in binance_mytrades()

daroczig / binancer

An R client to the Public Rest API for Binance.

https://daroczig.github.io/binancer

54 stars 57 forks source link

Error in binance_mytrades() #3

Closed PatronMaster closed 6 years ago

PatronMaster commented 6 years ago

You have an error in binance_mytrades(), you write setnames instead of setNames.

Amazing job. Thanks Now I need 1 week to understand all this code.

YsoSirius commented 6 years ago

setnames is correct. Its a function from the data.table package. This just formats the column names of the table to lower case and adds a "_" between words.

daroczig commented 6 years ago

Sorry for the late reply -- did not get notified of these tickets. @YsoSirius is correct, using setnames from data.table is on purpose instead of setNames -- although it seems it's not imported correctly, so fixing it