search

daroczig / binancer

An R client to the Public Rest API for Binance.
https://daroczig.github.io/binancer
54 stars 57 forks source link

Add timeout option #7

Closed dimitry-ishenko closed 4 years ago

dimitry-ishenko commented 6 years ago

With an unreliable connection calls to binance_klines() will sometimes hang and never return. The httr package supports timeout() option for the GET() function: https://rdrr.io/cran/httr/man/timeout.html

Ideally this option would be exposed in binancer or at least a sane default chosen (if there is one :smile: )

daroczig commented 6 years ago

Thanks, this is a good suggestion and pretty easy to implement -- I can get back to this in a couple weeks after the eRum 2018 conference

daroczig commented 4 years ago

Sorry for the long delay with this :/ Some updates just went out with better error handling -- can you please check if it's still an issue?

dimitry-ishenko commented 4 years ago

Feel free to close. I've moved on