daroczig / fbRads

Analyze and manage Facebook ads from R using this client library to access their Marketing APIs
GNU Affero General Public License v3.0
151 stars 57 forks source link

Update default API version to v3.2 #113

Closed RickPack closed 5 years ago

RickPack commented 5 years ago

Readme Examples that specify a version of the Facebook Ads API cause this error, which might be called "catastrophic" (?) given nothing is returned. "(#2635) You are calling a deprecated version of the Ads API. Please update to the latest version: v3.2."

I plan to offer a pull request soon that simply changes the "version = '3.0" reference to "version = '3.2'", which worked for at least this example: accounts <- fbad_get_my_ad_accounts(token, version = '3.2')

Can you assign this issue to me?

daroczig commented 5 years ago

Sorry, but that's a bit more complex -- bumping the default version would require checking the full changelog to see what parts of the current fbRads functions are affected: https://developers.facebook.com/docs/graph-api/changelog/version3.2

If there are no breaking changes, then we can bump the version, otherwise some other changes will be required as well. Until then, I'd suggest calling fbad_init with your choice of version and all further fbRads calls will use that.

daroczig commented 5 years ago

sorry, I totally forgot about this one, but bumped the most recent API version to 3.3

RickPack commented 5 years ago

Thank you!