Closed DanChaltiel closed 10 months ago
thanks! sorry that it took "some" time to take a look :zipper_mouth_face: I've pushed some code style updates and merging after the CI/CD tests run
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
cc4b608
) 80.76% compared to head (f36d54d
) 82.39%. Report is 18 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
When you log a warning or an error, the condition is thrown again after the log message.
Therefore, here is a pull request to muffle these unnecessary messages.
I think it is really interesting for warnings, but I might have been carried away with errors, it might be not that useful. The
getOptions()
part also.