search

daroczig / logger

A lightweight, modern and flexible, log4j and futile.logger inspired logging utility for R
https://daroczig.github.io/logger
280 stars 41 forks source link

Allow log_shiny_input_changes to have different init level #103

Closed taekeharkema closed 10 months ago

taekeharkema commented 2 years ago

Hi,

I wanted to use logger::log_shiny_input_changes in a Shiny-app we're building, but was bothered by the fact that the default shiny-inputs are logged at a static INFO-level. It would be nice if that was flexible. The current PR simply takes the level of the level argument provided by log_shiny_input_changes instead.

Is this something you'd be willing to consider?

I added some tests, but they rely on internal structure of the Shiny-package, as the function checks whether the shiny app isRunning(), and apparently and unfortunately it is not within a testServer.

daroczig commented 10 months ago

Sorry that I overlooked this contribution for so long time -- this is awesome, thanks!! :bow: