search

daroczig / logger

A lightweight, modern and flexible, log4j and futile.logger inspired logging utility for R
https://daroczig.github.io/logger
285 stars 42 forks source link

Add/26 return char #133

Closed r2evans closed 7 months ago

daroczig commented 7 months ago

@r2evans I've refactored a bit, but hopefully this is in line with the expectations/use-case -- please let me know. In short, instead of creating an as.character fn, the log fns now return both the formatted log messages and the (layouted) record, so the user can pick either via the list elements.

If you might have time to experiment with it over the weekend, that would be great, as I'm planning to release to CRAN soon (I promised that after a few nudges in other threads). No hard feelings if you don't get there -- my bad I've been sitting on this for so long.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.22%. Comparing base (d35a254) to head (c0578d8).

Files Patch % Lines
R/logger.R 96.15% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #133 +/- ## ========================================== + Coverage 83.95% 84.22% +0.27% ========================================== Files 10 10 Lines 561 577 +16 ========================================== + Hits 471 486 +15 - Misses 90 91 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

r2evans commented 7 months ago

Not this weekend, but I'll take a look later. Thanks!

daroczig commented 7 months ago

Thanks a ton! :bow:

I'm going to merge this for now, but we can revisit later anytime -- so please do post your findings when you have a chance.