search

daroczig / logger

A lightweight, modern and flexible, log4j and futile.logger inspired logging utility for R
https://daroczig.github.io/logger
285 stars 42 forks source link

Include log_level args explicitly in log_* wrappers #143

Closed MichaelChirico closed 7 months ago

MichaelChirico commented 7 months ago

Closes #140

NEWS is left out for now as I'm not sure whether to classify this change as a 'fix' or a 'feature'.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.95%. Comparing base (ec619ce) to head (10e59d7). Report is 9 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #143 +/- ## ======================================= Coverage 83.95% 83.95% ======================================= Files 10 10 Lines 561 561 ======================================= Hits 471 471 Misses 90 90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

daroczig commented 7 months ago

Thanks for your work on this :bow: Yeah, this looks great. There was a minor issue, but after the above commits, all tests passed. Planning to merge by the end of the week -- if you can think of any good test examples, I'd highly appreciate that. I will go though the NEWS file as quote a few tickets have been resolved today, but if you can add your contributions, that would be great as well.

MichaelChirico commented 7 months ago

Added one simple test, PTAL.

For the NEWS, I will leave it to you how you want to organize the entry -- not sure if it's a fix or a feature in this case.