search

daroczig / logger

A lightweight, modern and flexible, log4j and futile.logger inspired logging utility for R
https://daroczig.github.io/logger
280 stars 41 forks source link

Passwords recorded with log_shiny_input_changes #80

Closed pvictor closed 3 years ago

pvictor commented 3 years ago

Hello,

Passwords entered with passwordInput are logged with log_shiny_input_changes, it can be a little embarrassing. I don't think there's any way to differentiate passwordInput from the other ones server-side. Maybe add a warning in documentation or the possibility to exclude an input from logging ?

Best,

Victor

daroczig commented 3 years ago

Great point -- thanks for reporting this! I've pushed an update at #81 to allow excluding inputs from the auto-logging -- I hope that works, so please test and report back.

pvictor commented 3 years ago

Nice, thank you! Note that if you are using passwordInput into shiny modules, you'll have to do something like:

excluded_inputs = c("password", NS("my-module-ID", "password"))

Otherwise you'll have to allow regex into excluded_inputs, but it should be manageable and resolve the problem already, so thanks!

Victor