search

daroczig / logger

A lightweight, modern and flexible, log4j and futile.logger inspired logging utility for R
https://daroczig.github.io/logger
280 stars 41 forks source link

Add log rotation to appender_tee #82

Closed stPhena closed 3 years ago

stPhena commented 3 years ago

I have modified appender_tee() to allow passing parameters for log file rotation.

daroczig commented 3 years ago

awesome, thanks :+1: can you please review the above two minor suggestions?

codecov-io commented 3 years ago

Codecov Report

Merging #82 (9473091) into master (7696645) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   78.82%   78.94%   +0.12%     
==========================================
  Files          10       10              
  Lines         510      513       +3     
==========================================
+ Hits          402      405       +3     
  Misses        108      108
Impacted Files Coverage Δ
R/appenders.R 60.00% <100.00%> (+0.87%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7696645...9473091. Read the comment docs.

daroczig commented 3 years ago

thanks a lot