daroczig / logger

A lightweight, modern and flexible, log4j and futile.logger inspired logging utility for R
https://daroczig.github.io/logger
280 stars 41 forks source link

PSA: log_messages() creates a failure in with future plan(cluster)setups #91

Closed 1beb closed 2 years ago

1beb commented 2 years ago

log_messages is used to sink messages into the logger format. However, on a future cluster (plan(cluster)) it creates a problem. I believe this is the same type of problem that occurs with profvis.

daroczig commented 2 years ago

can you please post a minimal reproducible example of the problem?

1beb commented 2 years ago

I think this is outside of scope for logger. On a cluster, each machine would have it's own sink. So instead of sinking to a central log location you would have many, on different machines. I don't think this is a tractable problem without some kind of rdbms.

daroczig commented 2 years ago

Thanks for the update. And yeah, agreed that a central log destination, such as a database or a stream (e.g. kinesis) or exception tracker (e.g. sentry) could be a solution.

1beb commented 2 years ago

Sorry, I didn't see the notification back in January! Github notifications can be cluttered sometimes!