darold / ora2pg

Ora2Pg is a free tool used to migrate an Oracle database to a PostgreSQL compatible schema. It connects your Oracle database, scan it automatically and extracts its structure or data, it then generates SQL scripts that you can load into PostgreSQL.
http://www.ora2pg.com/
GNU General Public License v3.0
978 stars 341 forks source link

CJK characters are removed from index names #1649

Closed vgwidt closed 1 year ago

vgwidt commented 1 year ago

CJK characters such as Japanese are stripped out of index names in the following code: https://github.com/darold/ora2pg/blob/d03a1faa5f538519e2a71efb9554dea0030b8279/lib/Ora2Pg.pm#L10105

In my case this resulted in duplicate index names because they were originally differentiated using characters that were stripped.

It looks like it was updated here as part of https://github.com/darold/ora2pg/issues/1299.

darold commented 1 year ago

Commit 17399ea removes this line. Please confirm that there is no side effect with index name.

vgwidt commented 1 year ago

Works great with the line removed, thanks!