search

darold / pgFormatter

A PostgreSQL SQL syntax beautifier that can work as a console program or as a CGI. On-line demo site at http://sqlformat.darold.net/
PostgreSQL License
1.66k stars 100 forks source link

test psql_crosstab.sql failure: to_char(d, 'Mon') AS "" "month"" name" #304

Closed df7cb closed 1 year ago

df7cb commented 1 year ago

Hi,

pgformatter 5.4 doesn't pass its tests here:

PG_FORMAT=pg_format perl t/regress_test.pl
...
11:49:36 Running test on file t/pg-test-files/sql/psql.sql...
11:49:36    test ok.
11:49:36 Running test on file t/pg-test-files/sql/psql_crosstab.sql...
11:49:36    test failed!!!
11:49:36 -    to_char(d, 'Mon') AS """month"" name",
11:49:36 +    to_char(d, 'Mon') AS "" "month"" name",
11:49:36 Running test on file t/pg-test-files/sql/publication.sql...
11:49:37    test ok.

Full build log: https://pgdgbuild.dus.dg-i.net/job/pgformatter-binaries/22/architecture=amd64,distribution=sid/console#console-section-7

darold commented 1 year ago

Right, fixed with commit e86c494f.

df7cb commented 1 year ago

Thanks! Could you tag a new release with that, or would you prefer to wait?

darold commented 1 year ago

I'm traveling to Togo but I will try to fix some other reported issues during my flight and probably tag a new release this weekend. Thanks Christoph.

df7cb commented 1 year ago

Have a nice trip!

darold commented 1 year ago

Thanks, release published.

df7cb commented 1 year ago

Thanks!