darold / squidanalyzer

Squid Analyzer parses Squid proxy access log and reports general statistics about hits, bytes, users, networks, top URLs, and top second level domains. Statistic reports are oriented toward user and bandwidth control.
http://squidanalyzer.darold.net/
126 stars 36 forks source link

[Squid Analyzer 6.4] reports do not display correctly in Iceweasel 38.5.0 (ESR) #115

Closed dbareiro closed 8 years ago

dbareiro commented 8 years ago

Hi, Darold.

I found some problems to view reports in Iceweasel ESR. I had no problem in Chromium 47.0.2526.80, both versions provided by Debian Jessie. Below I attach some screenshots.

Chormium:

chromium1 chromium2 chromium3 chromium4 chromium5

Iceweasel ESR:

iceweasel1 iceweasel2 iceweasel3 iceweasel4 iceweasel5

Can you reproduce it (including with Firefox)?

Thanks in advance.

Best regards, Daniel

darold commented 8 years ago

I can not reproduce this issue with iceweasel 24.3.0 or firefox. I think you need to overwrite the resources files. From SquidAnalyzer source repository just proceed as follow:

sudo cp -rf resources/* /var/www/squidanalyzer/

if your output directory is /var/www/squidanalyzer/

Let us know.

Regards,

dbareiro commented 8 years ago

Hi, Darold.

Thanks for your reply.

I can not reproduce this issue with iceweasel 24.3.0 or firefox

I have not tried with a version so old of Iceweasel. But I could find this problem with Iceweasel 38.5.0 (ESR) on Debian stable (Jessie). Below I've annexed some links to install this version of Firefox/Iceweasel:

https://www.mozilla.org/en-US/firefox/organizations/ http://mozilla.debian.net/ (selecting "esr" in the drop down for "version")

I think you need to overwrite the resources files

The files appear to be those corresponding to version 6.4:

ws1:/usr/src/squidanalyzer-6.4/resources# ll
total 136
-rw-rw-r-- 1 operador operador 102194 dic 19 06:53 flotr2.js
drwxrwxr-x 2 operador operador   4096 dic 19 06:53 images
-rw-rw-r-- 1 operador operador  17262 dic 19 06:53 sorttable.js
-rw-rw-r-- 1 operador operador   7640 dic 19 06:53 squidanalyzer.css
ws1:/usr/src/squidanalyzer-6.4/resources# diff squidanalyzer.css /var/www/squidanalyzer/squidanalyzer.css 
ws1:/usr/src/squidanalyzer-6.4/resources# diff sorttable.js /var/www/squidanalyzer/sorttable.js 
ws1:/usr/src/squidanalyzer-6.4/resources# diff squidanalyzer.css /var/www/squidanalyzer/squidanalyzer.css

In the image files, it seems that there is one file that was not copied, although I do not think that's the cause of the problem mentioned with Iceweasel:

ws1:/var/www/squidanalyzer/images# ll
total 48
-rw-r--r-- 1 root root  1381 dic 19 09:38 back-arrow.png
-rw-r--r-- 1 root root   730 dic 19 09:38 cursor.png
-rw-r--r-- 1 root root   929 dic 19 09:38 domain.png
-rw-r--r-- 1 root root  3575 dic 19 09:38 info.png
-rw-r--r-- 1 root root 23210 dic 19 09:38 logo-squidanalyzer.png
-rw-r--r-- 1 root root   863 dic 19 09:38 network.png
-rw-r--r-- 1 root root   867 dic 19 09:38 user.png

ws1:/usr/src/squidanalyzer-6.4/resources/images# ll
total 52
-rw-rw-r-- 1 operador operador  1381 dic 19 06:53 back-arrow.png
-rw-rw-r-- 1 operador operador   730 dic 19 06:53 cursor.png
-rw-rw-r-- 1 operador operador   929 dic 19 06:53 domain.png
-rw-rw-r-- 1 operador operador  3575 dic 19 06:53 info.png
-rw-rw-r-- 1 operador operador 23210 dic 19 06:53 logo-squidanalyzer.png
-rw-rw-r-- 1 operador operador   863 dic 19 06:53 network.png
-rw-rw-r-- 1 operador operador   801 dic 19 06:53 up-arrow.png <==== This is the missing file
-rw-rw-r-- 1 operador operador   867 dic 19 06:53 user.png

Thanks for your time.

Best regards, Daniel

dbareiro commented 8 years ago

Hi, Darold.

I just did a test with Iceweasel 43.0.1 in Debian and here I am also seeing this problem.

Let me know, please.

Thanks!

Best regards, Daniel

darold commented 8 years ago

I would like to help but iceweasel can't be installed in my ubuntu 12.04:

gilles@devel:~$ sudo apt-get install -t precise-backports iceweasel
Reading package lists... Done
Building dependency tree       
Reading state information... Done
Note, selecting 'firefox' instead of 'iceweasel'
firefox is already the newest version.
0 upgraded, 0 newly installed, 0 to remove and 11 not upgraded.

Then using Firefox 43.0 I'm not able to reproduce your issue.

Please send me the generated html file where graphs are broken I will look at source code if there's any html broken.

dbareiro commented 8 years ago

Hi, Darold.

I send you the generated HTML files where I found this inconvenient. I used relative names to their locations, replacing / with _.

broken_htmls.zip

Thanks for your time.

Best regards, Daniel

darold commented 8 years ago

Ok, after installing iceweasel 38 I'm able to reproduce your issue. Unfortunately, it works great on other browser and especially in Firefox so I'm afraid it might be a iceweasel issue. I will lokk further later this night to see if I can find something. I will let you know.

Best regards

dbareiro commented 8 years ago

Hi, Darold.

Ok, after installing iceweasel 38 I'm able to reproduce your issue. Unfortunately, it works great on other browser and especially in Firefox so I'm afraid it might be a iceweasel issue.

In Firefox I have not tried, but in Chromium 47.0.2526.80 I had no problem. Now I just test with Konqueror 4.14.2 and I could not reproduce it there.

I will lokk further later this night to see if I can find something. I will let you know.

Thank you very much!

Best regards, Daniel

darold commented 8 years ago

Hi,

I was not able to find a quick workaround and don't have more time to spend on this issue. I think this is an Iceweasel related problem, Firefox, Chrome and Konqueror works fine. Please use one of these browsers until next major release. I will replace the flotr2 javascript chart library and use a new interface based on bootstrap, perhaps this issue will be solved too with this new code.

Best regards,

dbareiro commented 8 years ago

Hi, Darold.

I was not able to find a quick workaround and don't have more time to spend on this issue. I think this is an Iceweasel related problem, Firefox, Chrome and Konqueror works fine. Please use one of these browsers until next major release. I will replace the flotr2 javascript chart library and use a new interface based on bootstrap, perhaps this issue will be solved too with this new code.

No problem. I appreciate the time you took to check this and the one you will take to make these changes in a next major release.

It is strange that the javascript library has different results in Firefox and Iceweasel. I thought they both used the same javascript engine. Maybe they have some differences.

Happy Holidays!

Best regards, Daniel

dbareiro commented 8 years ago

Hi, Darold.

I just wanted to let you know that today I was doing some testing with Bacula in a virtual machine with Windows Server 2012 64-bit and I've taken this opportunity to doing a test accessing from Firefox 43.0.2 to SquidAnalyzer and I also found this problem with Firefox. Below I attach some screenshots.

windows2012_1 windows2012_3 windows2012_2 windows2012_4 windows2012_5

For now I will use other browsers, but I wanted to let you know this.

Best regards, Daniel

darold commented 8 years ago

Hi Daniel,

I was able to reproduce the issue with latest Firefox update. Latest commit 72a60e5 might solves the issue. Let us know.

Best regards,

dbareiro commented 8 years ago

Hi, Darold.

Great! I just test the patch with Iceweasel 38.5.0 (ESR) and the graphics are now displayed correctly. This patch also seems to solve the problem with the "Top Domains" and "MIME Types" charts. Same results in Firefox 43.0.3.

It may be useful to publish a new tarball for those who use a newer versions of Firefox/Iceweasel.

Thank you very much!

Best regards, Daniel

darold commented 8 years ago

Yes I will look at pending issues and feature requests and publish a new release after that.

Thanks for the feedback.