search

darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Remove algorithm dependencies #117

Closed as6520 closed 3 years ago

as6520 commented 3 years ago

This PR removes algorithm-specific requirements from sail-on-client. This simplifies the installation since the user needs to only clone and install the algorithm that they need to run rather than installing algorithms from all domains. It also fixes dependency resolution issues that occur when requirements for the algorithms are conflicting or if they are not up to date with what the client pipfile/requirements has.

Depends on #116

codecov[bot] commented 3 years ago

Codecov Report

Merging #117 (ff74928) into master (a8439c9) will decrease coverage by 0.178%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #117       +/-   ##
=============================================
- Coverage   93.304%   93.126%   -0.178%     
=============================================
  Files           39        39               
  Lines         2285      2313       +28     
=============================================
+ Hits          2132      2154       +22     
- Misses         153       159        +6
Impacted Files Coverage Δ
sail-on-client/sail_on_client/utils.py 90.625% <0.000%> (-9.375%) :arrow_down:
...-on-client/sail_on_client/protocol/ond_protocol.py 69.540% <0.000%> (+0.987%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8439c9...ff74928. Read the comment docs.