search

darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Fix characterization #119

Closed as6520 closed 3 years ago

as6520 commented 3 years ago

The master has a bug in the conditional execution of characterization. This results in characterization not executing at all. This PR fixes the condition when characterization is skipped. The characterization shouldn't execute when a baseline is added only for computing reaction performance.

Depends #118

codecov[bot] commented 3 years ago

Codecov Report

Merging #119 (979b64a) into master (a8439c9) will decrease coverage by 0.028%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #119       +/-   ##
=============================================
- Coverage   93.304%   93.276%   -0.028%     
=============================================
  Files           39        39               
  Lines         2285      2320       +35     
=============================================
+ Hits          2132      2164       +32     
- Misses         153       156        +3
Impacted Files Coverage Δ
sail-on-client/sail_on_client/utils.py 90.625% <0.000%> (-9.375%) :arrow_down:
...n-client/sail_on_client/protocol/localinterface.py 99.259% <0.000%> (+0.006%) :arrow_up:
...-on-client/sail_on_client/protocol/ond_protocol.py 72.222% <0.000%> (+3.669%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8439c9...979b64a. Read the comment docs.