search

darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Fix Test Failures in CI #138

Closed as6520 closed 3 years ago

as6520 commented 3 years ago

This PR fixes test failures that were occurring in the CI. There were two types of failures here

  1. Metric Failures: These were caused by the upstream repository introducing a lot of additional thresholds in the metrics. To fix the problem, we updated the expected values for the metrics.
  2. Session Termination constraint in Evaluate: This was caused by a session termination constraint being added to evaluate. Since this can't be addressed in this repository, we have filed https://github.com/darpa-sail-on/Sail-On-API/issues/20 and are skipping the test.
codecov[bot] commented 3 years ago

Codecov Report

Merging #138 (ead00c6) into master (8d95153) will decrease coverage by 0.583%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #138       +/-   ##
=============================================
- Coverage   92.645%   92.062%   -0.583%     
=============================================
  Files           40        43        +3     
  Lines         2393      2444       +51     
=============================================
+ Hits          2217      2250       +33     
- Misses         176       194       +18
Impacted Files Coverage Δ
sail-on-client/tests/test_parinterface.py 91.971% <0.000%> (-8.029%) :arrow_down:
...-on-client/sail_on_client/protocol/parinterface.py 90.741% <0.000%> (-6.481%) :arrow_down:
...-client/tests/test_activity_recognition_metrics.py 97.333% <0.000%> (-0.198%) :arrow_down:
sail-on-client/tests/test_transcription_metrics.py 97.333% <0.000%> (ø)
...-client/tests/test_image_classification_metrics.py 100.000% <0.000%> (ø)
...client/tests/image_classification_metric_values.py 100.000% <0.000%> (ø)
...client/tests/activity_recognition_metric_values.py 100.000% <0.000%> (ø)
...ail-on-client/tests/transcription_metric_values.py 100.000% <0.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 75f4f72...ead00c6. Read the comment docs.

as6520 commented 3 years ago

Merging this branch without review since it does not affect the client and only fixes the test.