darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Refactor protocol to reduce complexity #139

Closed as6520 closed 3 years ago

as6520 commented 3 years ago

This PR refactors the protocol to reduce the cognitive complexity of the protocols. It does the following

  1. Splits protocol into round, test, and protocol
  2. Uses data classes rather than a single toolset
  3. Add a decorator over all stages of the protocol to skip it rather than using conditionals.
codecov[bot] commented 3 years ago

Codecov Report

Merging #139 (40715ea) into master (e51fcc5) will increase coverage by 1.048%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #139       +/-   ##
=============================================
+ Coverage   92.062%   93.110%   +1.048%     
=============================================
  Files           43        35        -8     
  Lines         2444      1495      -949     
=============================================
- Hits          2250      1392      -858     
+ Misses         194       103       -91     
Impacted Files Coverage Δ
sail-on-client/sail_on_client/mock.py 90.000% <0.000%> (-5.918%) :arrow_down:
...-on-client/sail_on_client/pre_computed_detector.py 100.000% <0.000%> (ø)
...client/tests/test_activity_recognition_feedback.py
...client/tests/test_image_classification_feedback.py
sail-on-client/tests/test_checkpointer.py
sail-on-client/tests/test_localinterface.py
...-client/tests/test_activity_recognition_metrics.py
sail-on-client/tests/test_ond.py
sail-on-client/tests/test_precomputed_detector.py
...ient/tests/test_document_transcription_feedback.py
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e51fcc5...40715ea. Read the comment docs.