Closed as6520 closed 2 years ago
Merging #142 (3d3d5a1) into master (e51fcc5) will increase coverage by
1.030%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #142 +/- ##
=============================================
+ Coverage 92.062% 93.092% +1.030%
=============================================
Files 43 34 -9
Lines 2444 1491 -953
=============================================
- Hits 2250 1388 -862
+ Misses 194 103 -91
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e51fcc5...3d3d5a1. Read the comment docs.
We were using dynamic versioning in sail-on-client. This generates a version for the package based on the git tags and the distance from that tag. We are not moving away from it but since it is not supported in a version of poetry that we are using we are going to use manual versioning like https://github.com/darpa-sail-on/sail-on-client/pull/142/commits/3d3d5a175d70bed3b922109fd7bbf4a81a61c5ee until poetry releases a stable 1.2 version
Ok, sounds good
On Tue, Oct 12, 2021 at 12:13 PM Ameya Shringi @.***> wrote:
We were using dynamic versioning in sail-on-client. This generates a version for the package based on the git tags and the distance from that tag. We are not moving away from it but since it is not supported in a version of poetry that we are using we are going to use manual versioning like 3d3d5a1 https://github.com/darpa-sail-on/sail-on-client/commit/3d3d5a175d70bed3b922109fd7bbf4a81a61c5ee until poetry releases a stable 1.2 version
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/darpa-sail-on/sail-on-client/pull/142#issuecomment-941161387, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRZLNOKYSQV4KM5HCYJN2DUGRNENANCNFSM5FUDGMHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
This PR fixes the CI by making the following changes: