darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Test fix ci clean #142

Closed as6520 closed 2 years ago

as6520 commented 2 years ago

This PR fixes the CI by making the following changes:

  1. Downgrades poetry to 1.1.11 from 1.2.0a1 to fix the issue along the lines of https://github.com/python-poetry/poetry/issues/4085
  2. Removes dynamic versioning since it requires poetry plugin system that wouldn't be available until 1.2
  3. Removes the label assertion from feedback https://github.com/darpa-sail-on/Sail-On-API/pull/26. Since the labels are no longer provided for classification feedback. Have added #143 to track the problem
codecov[bot] commented 2 years ago

Codecov Report

Merging #142 (3d3d5a1) into master (e51fcc5) will increase coverage by 1.030%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #142       +/-   ##
=============================================
+ Coverage   92.062%   93.092%   +1.030%     
=============================================
  Files           43        34        -9     
  Lines         2444      1491      -953     
=============================================
- Hits          2250      1388      -862     
+ Misses         194       103       -91     
Impacted Files Coverage Δ
sail-on-client/sail_on_client/mock.py 90.000% <0.000%> (-5.918%) :arrow_down:
...-on-client/sail_on_client/pre_computed_detector.py 100.000% <0.000%> (ø)
sail-on-client/tests/test_utils.py
sail-on-client/tests/test_precomputed_detector.py
sail-on-client/tests/conftest.py
sail-on-client/tests/test_localinterface.py
...client/tests/image_classification_metric_values.py
sail-on-client/sail_on_client/utils.py
sail-on-client/tests/test_ond.py
...-client/tests/test_activity_recognition_metrics.py
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e51fcc5...3d3d5a1. Read the comment docs.

as6520 commented 2 years ago

We were using dynamic versioning in sail-on-client. This generates a version for the package based on the git tags and the distance from that tag. We are not moving away from it but since it is not supported in a version of poetry that we are using we are going to use manual versioning like https://github.com/darpa-sail-on/sail-on-client/pull/142/commits/3d3d5a175d70bed3b922109fd7bbf4a81a61c5ee until poetry releases a stable 1.2 version

cfunk1210 commented 2 years ago

Ok, sounds good

On Tue, Oct 12, 2021 at 12:13 PM Ameya Shringi @.***> wrote:

We were using dynamic versioning in sail-on-client. This generates a version for the package based on the git tags and the distance from that tag. We are not moving away from it but since it is not supported in a version of poetry that we are using we are going to use manual versioning like 3d3d5a1 https://github.com/darpa-sail-on/sail-on-client/commit/3d3d5a175d70bed3b922109fd7bbf4a81a61c5ee until poetry releases a stable 1.2 version

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/darpa-sail-on/sail-on-client/pull/142#issuecomment-941161387, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRZLNOKYSQV4KM5HCYJN2DUGRNENANCNFSM5FUDGMHA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.