Add CONDDA 5_14 Protocol on the client side - [merged]

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 16:37

Merges add-condda -> master

This MR add condda protocol. The protocol involves the following steps occurring in a loop

1. World Detection
2. Novelty Characterization
3. Novelty Adaption

where novelty adaption does not take any feedback from the server and relies on the clustering output

Depends on evm_based_novelty_detector !58 and sail-on !61

closes #10

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 16:39

added 1 commit

• c7a529a0 - Add configuration for condda_5_14 a1 and a2

Compare with previous version

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 16:39

changed the description

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 16:39

@waxlamp please review

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 16:40

@owl-uccs please review

[as6520]

In GitLab by @owl-uccs on Jun 15, 2020, 17:09

Commented on merge_framework/protocol/condda_config.py line 16

it is condda

[as6520]

In GitLab by @owl-uccs on Jun 15, 2020, 17:14

Commented on merge_framework/protocol/condda_config.py line 4

You can add clustering parameters 'FINCH', 'PFACT', 'HDBSCAN'

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 17:37

Commented on merge_framework/protocol/condda_config.py line 16

changed this line in version 3 of the diff

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 17:37

added 2 commits

• 394e63bc - Fix typo in default condda config
• 0b223e5f - Add red-light image as is in the toolset

Compare with previous version

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 17:37

Commented on merge_framework/protocol/condda_config.py line 16

Good catch! I have changed the test name

[as6520]

In GitLab by @as6520 on Jun 15, 2020, 17:38

Commented on merge_framework/protocol/condda_config.py line 4

Sure, could you provide the parameters that should be added for the three algorithms?

[as6520]

In GitLab by @owl-uccs on Jun 15, 2020, 18:15

Commented on merge_framework/protocol/condda_config.py line 4

Just name of clustering method, not internal parameter

[as6520]

In GitLab by @as6520 on Jun 16, 2020, 08:40

added 1 commit

• 5fd6f291 - Add empty dictionary for FINCH, PFACT and HDBSCAN params

Compare with previous version

[as6520]

In GitLab by @as6520 on Jun 16, 2020, 08:41

Commented on merge_framework/protocol/condda_config.py line 4

done

[as6520]

In GitLab by @waxlamp on Jun 17, 2020, 11:08

I am not the right person to review this, but the code looks ok.

[as6520]

In GitLab by @owl-uccs on Jun 17, 2020, 11:18

Commented on merge_framework/protocol/condda_config.py line 4

FINCH and PFACT are parameter free. I asked to add "clustering: key with two subkeyes "name" and""number_of_unknown_to_strat_clustering": 15, than you can delete "number_of_unknown_to_strat_clustering": 15, from EVM param. name can have 3 possible values FINCH, HDBSCAN, and PFACT

[as6520]

In GitLab by @owl-uccs on Jun 17, 2020, 11:19

Commented on merge_framework/protocol/condda_config.py line 48

detection_threshold should be 0.5

[as6520]

In GitLab by @owl-uccs on Jun 17, 2020, 11:19

Commented on config/condda_5_14_a2_nd.json line 28

detection_threshold should be 0.5

[as6520]

In GitLab by @owl-uccs on Jun 17, 2020, 11:19

Commented on config/condda_5_14_a1_nd.json line 28

detection_threshold should be 0.5

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:30

Commented on merge_framework/protocol/condda_config.py line 4

The suggestion would also require change in the constructor for both the algorithm. Could you create an MR in the https://gitlab.kitware.com/darpa-sail-on/evm_based_novelty_detector where the constructor for both the condda algorithms are modified with a new parameter called clustering_param. Since the dictionary would be passed to the algorithms during construction

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

Commented on merge_framework/protocol/condda_config.py line 48

changed this line in version 5 of the diff

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

Commented on config/condda_5_14_a2_nd.json line 28

changed this line in version 5 of the diff

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

Commented on config/condda_5_14_a1_nd.json line 28

changed this line in version 5 of the diff

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

added 1 commit

• 9cf0d42e - Modify detection threshold

Compare with previous version

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

Commented on merge_framework/protocol/condda_config.py line 48

Done

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

Commented on config/condda_5_14_a2_nd.json line 28

Done

[as6520]

In GitLab by @as6520 on Jun 18, 2020, 09:35

Commented on config/condda_5_14_a1_nd.json line 28

Done

[as6520]

In GitLab by @owl-uccs on Jun 18, 2020, 11:32

Commented on merge_framework/protocol/condda_config.py line 4

https://gitlab.kitware.com/darpa-sail-on/evm_based_novelty_detector/-/merge_requests/65

[as6520]

In GitLab by @as6520 on Jun 19, 2020, 15:27

added 1 commit

• 2c7e77e1 - Use characterization params

Compare with previous version

[as6520]

In GitLab by @as6520 on Jun 19, 2020, 15:27

Commented on merge_framework/protocol/condda_config.py line 4

Done

[as6520]

In GitLab by @owl-uccs on Jun 19, 2020, 15:41

done

[as6520]

In GitLab by @owl-uccs on Jun 19, 2020, 15:42

resolved all threads

[as6520]

In GitLab by @as6520 on Jun 19, 2020, 16:02

Could you please resolve this thread too?

[as6520]

In GitLab by @as6520 on Jun 19, 2020, 16:11

mentioned in commit 3d711b834b0647cb8e37b56a7a33bbe285cfe38d

[as6520]

In GitLab by @as6520 on Jun 19, 2020, 16:11

merged