search

darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Fix issues in different requests in parinterface - [merged] #47

Closed as6520 closed 3 years ago

as6520 commented 3 years ago

In GitLab by @as6520 on Jun 24, 2020, 09:01

Merges fix-parinterface -> master

This MR makes the following changes in ParInterface

  1. Create a feedback file in feedback request
  2. Remove redundant functionality from interface
  3. Fixes typing string in dataset_request and post_results

closes #17, #18, #19

as6520 commented 3 years ago

In GitLab by @as6520 on Jun 24, 2020, 09:02

@awk11 please review

as6520 commented 3 years ago

In GitLab by @awk11 on Jun 24, 2020, 09:12

LGTM

as6520 commented 3 years ago

In GitLab by @awk11 on Jun 24, 2020, 09:12

resolved all threads

as6520 commented 3 years ago

In GitLab by @as6520 on Jun 24, 2020, 09:17

mentioned in commit 1488e36a0ac768dff4ac537b7c34c62ae9dfbd33

as6520 commented 3 years ago

In GitLab by @as6520 on Jun 24, 2020, 09:17

merged