search

darpa-sail-on / sail-on-client

Client and Protcols for DARPA Sail On.
https://darpa-sail-on.github.io/sail-on-client/index.html
Other
2 stars 0 forks source link

Fix tests #88

Closed as6520 closed 3 years ago

as6520 commented 3 years ago

This branch fixes the tests that were causing CI to fail on branches that were based on master. The main reason for failure was the addition of evaluate function in the Sail-On-API repository. The evaluate function requires a complete test rather than the dummy test that was being used. This was causing failures in tests associated with par interface. Additional failures were being caused by variable name issues present that have been fixed in https://github.com/darpa-sail-on/Sail-On-API/pull/14.

Depends on https://github.com/darpa-sail-on/Sail-On-API/pull/14

codecov[bot] commented 3 years ago

Codecov Report

Merging #88 (b5ecfe1) into master (1042793) will decrease coverage by 0.008%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##            master       #88       +/-   ##
=============================================
- Coverage   93.375%   93.367%   -0.008%     
=============================================
  Files           30        30               
  Lines         1751      1764       +13     
=============================================
+ Hits          1635      1647       +12     
- Misses         116       117        +1
Impacted Files Coverage Δ
sail-on-client/sail_on_client/mock.py 95.918% <0.000%> (-2.041%) :arrow_down:
sail-on-client/tests/test_ond.py 100.000% <0.000%> (ø)
sail-on-client/tests/test_parinterface.py 100.000% <0.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1042793...b5ecfe1. Read the comment docs.

as6520 commented 3 years ago

Closing since the changes have been merged via #84