Preserve the offset and length when encoding an ArrayBuffer view

darrachequesne / notepack

A fast Node.js implementation of the latest MessagePack spec

MIT License

75 stars 19 forks source link

Preserve the offset and length when encoding an ArrayBuffer view #14

Open nkochakian opened 7 years ago

darrachequesne commented 7 years ago

Apart from the correctness of the implementation, do you have a use-case related to that change?

nkochakian commented 7 years ago

Personally, I don't, because I prefer to use Buffers, but this is a bug fix for the behavior of the current version. I also noticed that the node encoder supports typed arrays but the browser version doesn't. Removing typed array support would also work I guess.