search

darraghoriordan / eslint-plugin-nestjs-typed

Some eslint rules for working with NestJs projects
http://www.darraghoriordan.com
171 stars 34 forks source link

feat: all properties have explicit defined (#23 fixes) #27

Closed vic1707 closed 1 year ago

vic1707 commented 2 years ago

Since the original PR (#23) seems dead I took the liberty to copy the code and fix (I hope) all the requested changes.

At time of writting I think I just have to split the rule in two as asked in one of the comments.

vic1707 commented 2 years ago

The rules should be working in the current state, but the "non conflicting operators" one can be largely improved and needs to get the lists of incompatible decorators. @darraghoriordan do you know if the "typeCheckingDecorator" are all mutually exclusive (like setting IsString and IsBoolean are obviously incompatible)? If so it would drastically simplify the rule.

darraghoriordan commented 2 years ago

hey!

I had a look at this and the tests didn't pass on my machine. I downloaded it, yarn && yarn build && yarn test

darraghoriordan commented 2 years ago

oops. didn't mean to close

vic1707 commented 2 years ago

Got it, the add of the quick fix on one of the rules broke the tests

vic1707 commented 2 years ago

tests are now fixed @darraghoriordan. Before considering the merge I'd still need some clues about the non conflicting operators. Also I'm searching for a way to get the quickfix to figure out the indentation of the code

vic1707 commented 2 years ago

@darraghoriordan do we have an update on this?

darraghoriordan commented 2 years ago

heya! I need a bit of time to understand this one better. no eta unfortunately. I'll try to get to it in Sept 2022 though! 👍

vic1707 commented 2 years ago

okay 👍

vic1707 commented 1 year ago

Hello @darraghoriordan I'm not trying to be a pain in the ass or whatever but it's been 1 month since you've said you'll check my PR. Did you got the time to look at it? Maybe you need some help to understand my code?

darraghoriordan commented 1 year ago

Hello @darraghoriordan I'm not trying to be a pain in the ass or whatever but it's been 1 month since you've said you'll check my PR. Did you got the time to look at it? Maybe you need some help to understand my code?

hey! No sorry I just don't have the time. It's a large PR adding rules to the default set.

It will take me hours to review and test it and I have too many other things that are higher priority at the moment.

darraghoriordan commented 1 year ago

see previous comments

vic1707 commented 1 year ago

Okay, thx for the review and the release of the other pr