Closed lucavb closed 1 year ago
+1
done in v4.0
This issue does not seem fixed, as the peerDependencies are still having parser ^5 when doing an npm install
:
npm ERR! Found: @typescript-eslint/parser@6.1.0
npm ERR! node_modules/@typescript-eslint/parser
npm ERR! dev @typescript-eslint/parser@"6.1.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @typescript-eslint/parser@"^5.0.0" from @darraghor/eslint-plugin-nestjs-typed@4.0.1
npm ERR! node_modules/@darraghor/eslint-plugin-nestjs-typed
npm ERR! dev @darraghor/eslint-plugin-nestjs-typed@"4.0.1" from the root project```
ah it took so many changes to make the plugin work with tseslint 6 i missed the peer deep.
fixed in v4.0.2
thanks for letting me know
Thank you for the fast update, and for making this plugin! It's saved me and my team tons of effort. It should be bundled with NestJS/class-validator and enabled by default, it's so good. :D
Since I didn't see any issues regarding this yet :)
@typescript-eslint/parser was released recently https://github.com/typescript-eslint/typescript-eslint/releases/tag/v6.0.0 and I guess we are not the only ones that would like to upgrade (at least our renovate would like to 😅). Currently the
peerDependency
mentioned here is preventing us from upgrading while using this package. I haven't tested whether this requires any code changes to this package.Besides that, thanks for the package :)